chore(API docs): update header of angular-patternfly API Docs site#624
chore(API docs): update header of angular-patternfly API Docs site#624jeff-phillips-18 merged 1 commit intopatternfly:masterfrom dabeng:update-header
Conversation
dtaylor113
left a comment
dtaylor113
left a comment
There was a problem hiding this comment.
We need to limit all changes to just css under .showcase
| padding-top: 20px; | ||
| transition: padding-left 0.2s cubic-bezier(0.35, 0, 0.25, 1); | ||
| } | ||
| header .navbar.navbar-default { |
There was a problem hiding this comment.
Hi, this will affect every <header> element. We need to just limit this to <header>'s under showcase. Ie:
.showcase > header {
...
}
| @@ -0,0 +1,537 @@ | |||
| .text-overflow-pf { | |||
There was a problem hiding this comment.
You are overwritting text-overflow-pf for the entire application. This needs to be limited to just .showcase
jeff-phillips-18
left a comment
jeff-phillips-18
left a comment
There was a problem hiding this comment.
Agree with @dtaylor113. All the CSS selectors being added should ONLY effect the header bar. Rather than using the header element for the selector, add 'showcase' class to the header then for everything below, use that to ensure no unexpected changes are made.
For the navbar, please do the same so as not to interfere with any navbar-sidebar items that could become part of the examples.
In short, let's make sure that none of the CSS being added to the examples effect anything that is not intended.
| .showcase-contribute i.code { | ||
| color: #852009; | ||
| } | ||
| footer { |
There was a problem hiding this comment.
Is this used anywhere? I don't see any footer as part of the page.
| transition: padding-left 0.2s cubic-bezier(0.35, 0, 0.25, 1); | ||
| } | ||
| header .navbar.navbar-default { | ||
| background: #040404 !important; |
There was a problem hiding this comment.
Shouldn't we be using colors from the Patternfly palette?
There was a problem hiding this comment.
Why so many !important's?
|
@dtaylor113 @jeff-phillips-18 I've updated the CSS part. the main structure of the less is as below: For your above questions, answered as following:
|
|
The structure of this less file is what I was looking for thanks. If the footer can not be made more specific to the showcase components, then I would not include its CSS here. IMO, we should be using the Patternfly color palette for the showcase apps (and for Patternfly.org for that matter) but I'm OK with that being done as an overall Patternfly.org/Repo effort if others agree. |
Looks good, just needs to be pushed to this PR |
|
@dtaylor113 , please review again. |
|
I've reviewed per @dtaylor113 's comments. I believe they are all resolved. |
4 participants
Hi @jeff-phillips-18 , the class "showcase" has been removed from the body tag in this PR.